forked from yoone/API
1
0
Fork 0

refactor(order.service): 简化订单ID验证逻辑并优化查询条件

移除冗余的空值检查,使用可选链操作符简化验证
仅在validIds非空时添加查询条件
This commit is contained in:
tikkhun 2026-01-06 10:54:47 +08:00
parent 907228297d
commit a22e302c4e
1 changed files with 4 additions and 10 deletions

View File

@ -2461,17 +2461,9 @@ export class OrderService {
} }
try { try {
// 空值检查和数据清理
if (!ids || !Array.isArray(ids)) {
throw new Error('订单ID列表不能为空');
}
// 过滤掉NaN和非数字值只保留有效的数字ID // 过滤掉NaN和非数字值只保留有效的数字ID
const validIds = ids.filter(id => Number.isFinite(id) && id > 0); const validIds = ids?.filter?.(id => Number.isFinite(id) && id > 0);
if (validIds.length === 0) {
throw new Error('未提供有效的订单ID');
}
const dataSource = this.dataSourceManager.getDataSource('default'); const dataSource = this.dataSourceManager.getDataSource('default');
@ -2479,7 +2471,9 @@ export class OrderService {
return await dataSource.transaction(async manager => { return await dataSource.transaction(async manager => {
// 准备查询条件 // 准备查询条件
const whereCondition: any = {}; const whereCondition: any = {};
if(validIds.length > 0){
whereCondition.id = In(validIds); whereCondition.id = In(validIds);
}
// 获取订单、订单项和物流信息 // 获取订单、订单项和物流信息
const orders = await manager.getRepository(Order).find({ const orders = await manager.getRepository(Order).find({