From a22e302c4ec169d9fc9864a972abc32bc9d3fdb9 Mon Sep 17 00:00:00 2001 From: tikkhun Date: Tue, 6 Jan 2026 10:54:47 +0800 Subject: [PATCH] =?UTF-8?q?refactor(order.service):=20=E7=AE=80=E5=8C=96?= =?UTF-8?q?=E8=AE=A2=E5=8D=95ID=E9=AA=8C=E8=AF=81=E9=80=BB=E8=BE=91?= =?UTF-8?q?=E5=B9=B6=E4=BC=98=E5=8C=96=E6=9F=A5=E8=AF=A2=E6=9D=A1=E4=BB=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 移除冗余的空值检查,使用可选链操作符简化验证 仅在validIds非空时添加查询条件 --- src/service/order.service.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/service/order.service.ts b/src/service/order.service.ts index e75ea8e..5c5e47f 100644 --- a/src/service/order.service.ts +++ b/src/service/order.service.ts @@ -2461,17 +2461,9 @@ export class OrderService { } try { - // 空值检查和数据清理 - if (!ids || !Array.isArray(ids)) { - throw new Error('订单ID列表不能为空'); - } // 过滤掉NaN和非数字值,只保留有效的数字ID - const validIds = ids.filter(id => Number.isFinite(id) && id > 0); - - if (validIds.length === 0) { - throw new Error('未提供有效的订单ID'); - } + const validIds = ids?.filter?.(id => Number.isFinite(id) && id > 0); const dataSource = this.dataSourceManager.getDataSource('default'); @@ -2479,7 +2471,9 @@ export class OrderService { return await dataSource.transaction(async manager => { // 准备查询条件 const whereCondition: any = {}; - whereCondition.id = In(validIds); + if(validIds.length > 0){ + whereCondition.id = In(validIds); + } // 获取订单、订单项和物流信息 const orders = await manager.getRepository(Order).find({